[Bug 760873] GstGLVideoMixerPad vertex_buffer leaks when pad dynamic removed

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=760873

comicfans44 <comicfans44 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #9 from comicfans44 <comicfans44 at gmail.com> ---
I think this problem is not resolved. after insert some debug trace, I can
confirm gst_gl_video_mixer_callback called after release_pad is called. maybe
lock needed 

gstaggregator srcpad thread runs:
gst_aggregator_aggregate_func-> 
gst_videoaggregator_aggregate->
gst_gl_mixer_aggregate_frames->
gst_gl_video_mixer_process_textures-> 
call gst_gl_video_mixer_callback on gl thread and wait it finish


but gst_gl_video_mixer_release_pad can be called from
gst_element_release_request_pad from any thread, these two thread should lock
on something to ensure not access the pad which may be destroied 




0:00:00.842702829 11505 0x7fffc8001540    glvideomixer
gstglvideomixer.c:1498:gst_gl_video_mixer_callback:<mixer:sink_0> gen
vertex_buffer
0:00:00.845170634 11505 0x7fffd8002f00    glvideomixer
gstglvideomixer.c:866:gst_gl_video_mixer_release_pad:<mixer:sink_0> release_pad
0:00:00.848196268 11505 0x7fffc8001540    glvideomixer
gstglvideomixer.c:1498:gst_gl_video_mixer_callback:<mixer:sink_0> gen
vertex_buffer

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.