[Bug 763799] alsasrc: should not always assume that 8 channels implies 7.1 setup

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763799

--- Comment #1 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Guillaume Desmottes from comment #0)
> But I'm wondering if gst_audio_ring_buffer_set_channel_positions() shouldn't
> also use the channel positions returned by alsa instead of the hardcoded
> alsa_position array. In this case
> gst_audio_ring_buffer_set_channel_positions() shouldn't be modified as both
> array will then be equals (8 GST_AUDIO_CHANNEL_POSITION_NONE).
> asink as the code paths are pretty symetric.

Actually, alsasrc/alsasink already query Alsa for the channel map (using
snd_pcm_get_chmap()) and passes this as channel position to the ringbuffer.
See
https://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/ext/alsa/gstalsasink.c#n911
So this work is already done.

But as long as gstalsa.c:caps_add_channel_configuration() keeps assuming that 8
channels implies 7.1 gst will reorder things.
Shouldn't caps_add_channel_configuration() use the channel map from ALSA as
well?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.