[Bug 763711] splitmuxsink: deadlock when one streams doesn't have regular buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763711

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324300|none                        |needs-work
             status|                            |

--- Comment #8 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 324300:
 --> (https://bugzilla.gnome.org/review?bug=763711&attachment=324300)

Please put some explanation in the commit message. It's always easier to find
things in the commit history with better commit messages.

::: gst/multifile/gstsplitmuxsink.c
@@ +1141,3 @@
+            splitmux->max_in_running_time);
+        event = gst_event_new_gap (pos, GST_CLOCK_TIME_NONE);
+        gst_pad_send_event (ctx->sinkpad, event);

How well did you test this, and with which mux formats? I'm not entirely sure
it won't introduce actual gaps in the playback of the resulting pieces with at
least some formats

@@ +1273,2 @@
       (GstPadProbeCallback) handle_mq_input, ctx, (GDestroyNotify)
       _pad_block_destroy_sink_notify);

Why did you move the pad probe from the multiqueue sink pad to the ghostpad?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.