[Bug 763968] qtdemux: Add check condition for fail case in get_duration function

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763968

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324407|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 324407:
 --> (https://bugzilla.gnome.org/review?bug=763968&attachment=324407)

::: gst/isomp4/qtdemux.c
@@ +834,3 @@
+
+          gst_qtdemux_get_duration (qtdemux, &duration);
+          if (duration > 0) {

Why do you remove the check for the return value here?

@@ +4422,3 @@

+  if (G_UNLIKELY (QTSEGMENT_IS_EMPTY (&stream->
+              segments[stream->segment_index]))) {

No useless indentation changes please :)

@@ +5187,3 @@
   /* If we're doing a keyframe-only trickmode, only push keyframes on video
streams */
+  if (G_UNLIKELY (qtdemux->segment.
+          flags & GST_SEGMENT_FLAG_TRICKMODE_KEY_UNITS)) {

No useless indentation changes please :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.