[Bug 752213] tee: Avoid race condition while forwarding sticky events
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Mar 21 09:17:12 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=752213
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #324415|none |reviewed
status| |
--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 324415:
--> (https://bugzilla.gnome.org/review?bug=752213&attachment=324415)
Please add some more explanation to the commit message about what exactly the
problem here is. Why is this needed at all? All sticky events are going to be
copied over before the pad is added to the element, once the pad is added to
the element all events will be passed through as usual. Where is the race?
::: plugins/elements/gsttee.c
@@ +306,3 @@
gst_tee_init (GstTee * tee)
{
+ g_rec_mutex_init (&tee->mutex_events);
Why does this need a recursive mutex?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list