[Bug 762884] rtspsrc: allow to control headers via properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762884

--- Comment #7 from Nicola <lists at svrinformatica.it> ---
(In reply to Sebastian Dröge (slomo) from comment #6)
> Review of attachment 322686 [details] [review]:
> 
> Maybe instead a signal would be useful that allows the application to do
> whatever it wants with the GstRTSPMessage before it is sent?

OK, I'll see if I can find some free time, for my actual needs this patch is ok
as is

> 
> ::: gst/rtsp/gstrtspsrc.c
> @@ +4253,3 @@
> +  GST_DEBUG ("Appending extra header: \"%s: %s\"", field_name,
> field_content);
> +  gst_rtsp_message_remove_header_by_name (msg, field_name, -1);
> +  gst_rtsp_message_add_header_by_name (msg, field_name, field_content);
> 
> What if you want to add the same header multiple times with different
> content?

it is done in this way since for onvif we need to set a Range header and
override the one that gstreamer could set. Maybe this can be configurable. Not
sure if is still needed if we use a signal: if I understand correctly with a
signal an user can inspect and modify the header as he wants and so decide if
replace some specific field or set multiple times with different content

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.