[Bug 763999] New: NDK_HOST_SED no longer set in Android NDK 11b

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763999

            Bug ID: 763999
           Summary: NDK_HOST_SED no longer set in Android NDK 11b
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: cerbero
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: martin at surround.io
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

On recent cerbero builds with Android NDK 11, it appears the HOST_SED issue has
reappeared in a slightly different form; I'm seeing similar build breaks to
what we saw in https://bugzilla.gnome.org/show_bug.cgi?id=750162:

WARNING: Error importing command bundlesource:
 No module named setuptools.sandbox
Android NDK: WARNING: APP_PLATFORM android-23 is larger than
android:minSdkVersion 19 in /build/srio-camera/AndroidManifest.xml    
make: -n: Command not found
/bin/sh: 0: Illegal option -
[...]

In that bug, we fixed the issue by setting HOST_SED via NDK_HOST_SED.
Unfortunately, it looks like NDK_HOST_SED is no longer set either (and sed is
no longer in prebuilt/linux-x86_64/bin), causing builds to again fail with the
same issues we used to see in the previous bug.

Just to confirm the theory that sed is the culprit here, I tested the below
patch (obviously not one we would want to commit) and it fixed the issue.

Now, we could easily just set "HOST_SED := sed" and remove the current logic,
but I'm wondering how we can make this work in a cross-platform way. I'm open
to suggestions and am happy to help write and test a patch for a suggested
approach.

Test patch:
--- a/gstreamer-1.0.mk    2016-03-21 09:20:04.112243261 -0700
+++ b/gstreamer-1.0.mk    2016-03-21 09:20:17.340243653 -0700
@@ -71,6 +71,7 @@
         HOST_SED := $(strip $(wildcard $(HOST_PREBUILT)/sed$(HOST_EXEEXT)))
     endif
 endif
+HOST_SED := sed
 ifndef HOST_SED
     HOST_CMP := sed
 endif

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.