[Bug 642759] faceoverlay plugin: displays an SVG image over a detected face on a video stream

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=642759

--- Comment #10 from César Fabián Orccón Chipana <cfoch.fabian at gmail.com> ---
(In reply to Mathieu Duponchelle from comment #9)
> Review of attachment 324513 [details] [review]:
> 
> You should ask for review in a separate, new bug, not in a RESOLVED FIXED
> one from 2011 ;) I haven't actually tried your patch, but I assume it works
> for your use case, however you have reduced the negotiation capabilities of
> this element to nothing on your end, please fix that :)
> 
> ::: gst/faceoverlay/gstfaceoverlay.c
> @@ +82,3 @@
>      GST_PAD_SINK,
>      GST_PAD_ALWAYS,
> +    GST_STATIC_CAPS_ANY);
> 
> You are now saying that this plugin can get anything as an input, which
> means I should be able to push an encoded mp3 stream in its direction, is
> that the case?
> 
> @@ +87,3 @@
>      GST_PAD_SRC,
>      GST_PAD_ALWAYS,
> +    GST_STATIC_CAPS_ANY);
> 
> Same thing here, can this plugin output anything other than video/x-raw,
> format=[YUV, RGB] ?
I have decided to use sink template and src template as its children use.
> 
> @@ -93,1 +91,1 @@
> -GST_BOILERPLATE (GstFaceOverlay, gst_face_overlay, GstBin, GST_TYPE_BIN);
> +#define gst_face_overlay_parent_class parent_class
> 
> Is this needed at all ? I honestly don't know whether this was something
> defined by GST_BOILERPLATE and used in this file, it does not seem to be
> used in this diff's context.
> 
It defines parent_class that is used in original code.
> @@ -255,3 +254,3 @@
>    }
>  
> -  GST_LOG_OBJECT (filter, "overlay dimensions: %d x %d @ %d,%d",
> +  GST_DEBUG_OBJECT (filter, "overlay dimensions: %d x %d @ %d,%d",
> 
> Any good reason for promoting this to "DEBUG" ?
No. Changed as it was.

https://bugzilla.gnome.org/show_bug.cgi?id=764011

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.