[Bug 763745] Can not decode jpeg without huffman tables.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763745

--- Comment #4 from sonntex <sonntex at gmail.com> ---
I am trying to write some code to fix the problem. Example looks like:

diff --git a/omx/gstomxmjpegdec.c b/omx/gstomxmjpegdec.c
index 8e704ae..5eaa904 100644
--- a/omx/gstomxmjpegdec.c
+++ b/omx/gstomxmjpegdec.c
@@ -83,6 +83,54 @@ gst_omx_mjpeg_dec_is_format_change (GstOMXVideoDec * dec,
   return FALSE;
 }

+static void guarantee_huff_tables(GstOMXVideoDec * dec)
+{
+  GstOMXMJPEGDec *self = GST_OMX_MJPEG_DEC (dec);
+  OMX_ERRORTYPE err;
+  OMX_IMAGE_PARAM_HUFFMANTTABLETYPE param_huffman_table;
+
+  static const guint8 bit_ac_luminance[] =
+    { 0, 2, 1, 3, 3, 2, 4, 3, 5, 5, 4, 4, 0, 0, 1, 0x7d };
+  static const guint8 val_ac_luminance[] =
+    { 0x01, 0x02, 0x03, 0x00, 0x04, 0x11, 0x05, 0x12,
+      0x21, 0x31, 0x41, 0x06, 0x13, 0x51, 0x61, 0x07,
+      0x22, 0x71, 0x14, 0x32, 0x81, 0x91, 0xa1, 0x08,
+      0x23, 0x42, 0xb1, 0xc1, 0x15, 0x52, 0xd1, 0xf0,
+      0x24, 0x33, 0x62, 0x72, 0x82, 0x09, 0x0a, 0x16,
+      0x17, 0x18, 0x19, 0x1a, 0x25, 0x26, 0x27, 0x28,
+      0x29, 0x2a, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39,
+      0x3a, 0x43, 0x44, 0x45, 0x46, 0x47, 0x48, 0x49,
+      0x4a, 0x53, 0x54, 0x55, 0x56, 0x57, 0x58, 0x59,
+      0x5a, 0x63, 0x64, 0x65, 0x66, 0x67, 0x68, 0x69,
+      0x6a, 0x73, 0x74, 0x75, 0x76, 0x77, 0x78, 0x79,
+      0x7a, 0x83, 0x84, 0x85, 0x86, 0x87, 0x88, 0x89,
+      0x8a, 0x92, 0x93, 0x94, 0x95, 0x96, 0x97, 0x98,
+      0x99, 0x9a, 0xa2, 0xa3, 0xa4, 0xa5, 0xa6, 0xa7,
+      0xa8, 0xa9, 0xaa, 0xb2, 0xb3, 0xb4, 0xb5, 0xb6,
+      0xb7, 0xb8, 0xb9, 0xba, 0xc2, 0xc3, 0xc4, 0xc5,
+      0xc6, 0xc7, 0xc8, 0xc9, 0xca, 0xd2, 0xd3, 0xd4,
+      0xd5, 0xd6, 0xd7, 0xd8, 0xd9, 0xda, 0xe1, 0xe2,
+      0xe3, 0xe4, 0xe5, 0xe6, 0xe7, 0xe8, 0xe9, 0xea,
+      0xf1, 0xf2, 0xf3, 0xf4, 0xf5, 0xf6, 0xf7, 0xf8,
+      0xf9, 0xfa
+    };
+
+  GST_OMX_INIT_STRUCT (&param_huffman_table);
+  param_huffman_table.nPortIndex = GST_OMX_VIDEO_DEC
(self)->dec_in_port->index;
+  param_huffman_table.eHuffmanTable = OMX_IMAGE_HuffmanTableACLuma;
+  memcpy(param_huffman_table.nNumberOfHuffmanCodeOfLength, bit_ac_luminance,
sizeof(bit_ac_luminance));
+  memcpy(param_huffman_table.nHuffmanTable, val_ac_luminance,
sizeof(val_ac_luminance));
+
+  GST_DEBUG_OBJECT (self, "Port %d", param_huffman_table.nPortIndex);
+
+  err = gst_omx_component_set_parameter (GST_OMX_VIDEO_DEC (self)->dec,
OMX_IndexParamHuffmanTable, &param_huffman_table);
+  if (err != OMX_ErrorNone) {
+    GST_DEBUG_OBJECT (self, "Error %s (0x%08x)", gst_omx_error_to_string
(err), err);
+  } else {
+    GST_DEBUG_OBJECT (self, "Ok");
+  }
+}
+
 static gboolean
 gst_omx_mjpeg_dec_set_format (GstOMXVideoDec * dec, GstOMXPort * port,
     GstVideoCodecState * state)
@@ -94,5 +142,7 @@ gst_omx_mjpeg_dec_set_format (GstOMXVideoDec * dec,
GstOMXPort * port,
   port_def.format.video.eCompressionFormat = OMX_VIDEO_CodingMJPEG;
   ret = gst_omx_port_update_port_definition (port, &port_def) ==
OMX_ErrorNone;

+  guarantee_huff_tables (dec);
+
   return ret;
 }

If I try to set the table using gst_omx_component_set_parameter function it
returns "Error Unsupported index (0x8000101a)". If I try to get the table using
gst_omx_component_get_parameter it returns "Error Hardware (0x80001009)". Is
this future supported by openmax or should I add huffman table to jpeg before
decoding? Probably I have a mistake in my example?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.