[Bug 764034] preset: Use GST_PRESET_PATH as an extension of the system path, not a replacement of the user path

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764034

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324546|none                        |reviewed
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 324546:
 --> (https://bugzilla.gnome.org/review?bug=764034&attachment=324546)

Looks good apart from that.

The user dir > app dir > GST_PRESET_PATH > system dir order sounds right to me.

::: gst/gstpreset.c
@@ -412,0 +439,23 @@
+
+    if (have_env) {
+      GList *l;
... 20 more ...

Not freeing the PresetAndVersion structures?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.