[Bug 762207] flvmux: Ensure we use DTS when clipping running time

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762207

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This actually does not seem to do the right thing in general, and we should
probably defer this to the muxers as only they can know if doing this
assumption is ok for their use case or not.

Problematic for example is if you have a stream that has B frames but only DTS.
We would then generate a stream that has wrong PTS. And a stream with only DTS
but no PTS is perfectly valid, a decoder/parser can make up sensible PTS for
it.

The other problematic case is if there is a stream that sometimes does not have
PTS (e.g. only for the very first buffer) but always DTS. We would make up PTS
that might be completely off based on the actual PTS that are known.


I think this should be reverted and replaced with either proper PTS/DTS
conversion in h264parse, or muxer specific solutions if there's something a
muxer can do about it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.