[Bug 763403] bad: video sink: Post un-handled keyboard/mouse events as message to application

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=763403

--- Comment #5 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 323558
  --> https://bugzilla.gnome.org/attachment.cgi?id=323558
gtkbasesink: Post unhandled events

>-  if (GST_IS_PAD (pad)) {
>-    if (GST_IS_EVENT (event))
>-      ...
>-
>+  if (GST_IS_PAD (pad) && GST_IS_EVENT (event)) {
>+    ...
>+    gst_event_unref (event);
>     gst_object_unref (pad);
>   }
> }

Just for the record, this is not really equivalent. We would now leak the pad
in case where the pad is valid, but the event is not valid. The event
will/should always be valid here of course, so will not be a problem in
practice.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.