[Bug 761225] pad: Allow multiple conversion specifiers for request pads and don't require it at the very end

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=761225

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #320688|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 320688:
 --> (https://bugzilla.gnome.org/review?bug=761225&attachment=320688)

::: gst/gstelement.c
@@ +940,3 @@
       data = name + (str - templ->name_template);

+      /* If it has multiple convention specifiers, check them all. Each

convention -> conversion

@@ +950,3 @@
+        } else {
+          /* Can either be %s or %d or %u, do sanity checking for %d */
+          if (*(str + 1) == 'd') {

I think you can read after the string's memory here. Why would str+1 be a valid
pointer? *str might be '\0'.

Please also check all the other string parsing another time

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.