[Bug 620323] mpegaudioparse: Add support for LAME tags and adjust segments based on the padding information from it

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=620323

--- Comment #34 from Carlos Rafael Giani <dv at pseudoterminal.org> ---
(In reply to Christoph Reiter (lazka) from comment #33)
> > Ah, but you are talking about byte-level seeking. I was referring to operations in the time domain. It is my impression that the number of *samples* per frame is constant, but that in VBR MP3s, these fixed number of samples can be encoded with a varying bitrate. So, if downstream requests a time seek, then it should work.
> 
> Ah, yes, samples are constant. But afaik time based seeking just uses the
> xiph seek table and interpolation and thus isn't exact. If we are one frame
> of we might clip away the real signal.

Then I'd stick with the segment based approach. It works well (it is in use in
production here already), does not need any additional buffering, and can clip
exactly, because it relies on Xing/LAME/VBRI information. (For example, mpg123
also relies on the duration computed with Xing/LAME/VBRI data for trimming the
padding samples, and it works flawlessly.) The baseparse patch needs cleanup
though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.