[Bug 764361] gdpdepay: query for buffer allocator

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764361

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #325004|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 325004:
 --> (https://bugzilla.gnome.org/review?bug=764361&attachment=325004)

Generally makes sense, just some changes needed here :)

::: gst/gdp/gstgdpdepay.c
@@ +159,3 @@
   g_object_unref (this->adapter);
+  if (this->allocator)
+    gst_object_unref (this->allocator);

You also should get rid of the allocator in PAUSED->READY

@@ +521,3 @@
+  switch (transition) {
+    case GST_STATE_CHANGE_READY_TO_PAUSED:
+      gst_gdp_depay_decide_allocation (this);

This should happen after the caps are set on the srcpad... and whenever the
reconfigure flag is set on the srcpad

@@ +550,3 @@
+  GstCaps *caps;
+
+  caps = gst_pad_peer_query_caps (gdpdepay->srcpad, NULL);

You put your own srcpad caps into the query

@@ +577,3 @@
+    gst_caps_unref (caps);
+  if (query)
+    gst_query_unref (query);

You always have the query here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.