[Bug 752213] tee: Avoid race condition while forwarding sticky events

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752213

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #324940|none                        |needs-work
             status|                            |

--- Comment #31 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 324940:
 --> (https://bugzilla.gnome.org/review?bug=752213&attachment=324940)

::: plugins/elements/gsttee.c
@@ +567,3 @@
   gboolean res;

+  res = gst_pad_event_default (pad, parent, event);

You can't use gst_pad_event_default() here, that's racy and why I didn't do
that :)

But in the forward function you will *also* need to check the current pad
cookie and if it's wrong you additionally need to forward all events there.
That should fix the sticky event misordering problem

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.