[Bug 765927] new plugin: ICC (International Color Consortium) correction plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765927

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327203|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327203:
 --> (https://bugzilla.gnome.org/review?bug=765927&attachment=327203)

::: configure.ac
@@ +3021,3 @@
+translit(dnm, m, l) AM_CONDITIONAL(USE_SAMPLEICC, true)
+AG_GST_CHECK_FEATURE(SAMPLEICC, [ICC plugin], sampleicc, [
+  PKG_CHECK_MODULES(SAMPLEICC, sampleicc >= 1.6.8, HAVE_SAMPLEICC="yes", [

It might be better to use lcms, which is actually packaged by distributions :)

::: ext/icc/gsticc.cpp
@@ +254,3 @@
+  char buf[64];
+
+  g_print ("Profile:          '%s'\n", filename);

Use GST_MEMDUMP_OBJECT or something here

@@ +565,3 @@
+        g_error_new (GST_RESOURCE_ERROR, GST_RESOURCE_ERROR_NO_SPACE_LEFT,
+        "Unable to open allocate memory for lookup table!");
+    GstMessage *msg = gst_message_new_error (GST_OBJECT (icc), err, NULL);

Use the GST_ELEMENT_ERROR() macro

@@ +680,3 @@
+
+static void
+gst_icc_before_transform (GstBaseTransform * transform, GstBuffer * outbuf)

Doesn't GstVideoFilter or basetransform do that already? If not, why not? :)

@@ +838,3 @@
+plugin_init (GstPlugin * plugin)
+{
+  return (gst_element_register (plugin, "icc", GST_RANK_NONE, GST_TYPE_ICC));

icccorrect maybe? Something that better gives the intent

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.