[Bug 742878] decklink: Add initial support for 10bit YUV modes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=742878

--- Comment #29 from Vivia Nikolaidou <vivia at ahiru.eu> ---
(In reply to Sebastian Dröge (slomo) from comment #25)
> Review of attachment 326954 [details] [review]:
> 
> ::: sys/decklink/gstdecklinkvideosrc.cpp
> @@ +813,3 @@
> +          self->video_format != GST_DECKLINK_VIDEO_FORMAT_AUTO) {
> +        GST_WARNING_OBJECT (self, "Warning: mode=auto and format!=auto may \
> +                            not work");
> 
> Will mode!=auto && format==auto work as expected? I would also just make it
> an error and return GST_STATE_CHANGE_FAILURE here then

It might or might not. It will work if you accidentally picked the correct
format. Worst case, you get a black frame. I prefer to keep it, because nothing
explodes (black frame is also the result of choosing the wrong mode, for
instance), and under specific circumstances it might work.

Otherwise, I've corrected the patch and uploaded the new version. Please feed
back.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.