[Bug 765456] Strange bug re-encoding video with GST 1.8.1 on Mac OS 10.10

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765456

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327259|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327259:
 --> (https://bugzilla.gnome.org/review?bug=765456&attachment=327259)

Makes sense to me but seems like if it caused any problems before then this
will still cause problems in a racy way. We might expose the pad before the
first buffer, or not, depending on timing.

::: gst/playback/gstdecodebin2.c
@@ +5064,3 @@
+
+  caps = gst_pad_get_current_caps (GST_PAD_CAST (endpad));
+  has_fixed_caps = gst_caps_is_fixed (caps);

Current caps are always fixed, they might just be NULL too. You can just check
gst_pad_has_current_caps() here instead (and calling gst_caps_is_fixed(NULL)
gives an assertion).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.