[Bug 757258] gstalsasink: iec61937 (Non-linear PCM bitstreams) not correctly working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=757258

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #317330|none                        |needs-work
             status|                            |

--- Comment #12 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 317330:
 --> (https://bugzilla.gnome.org/review?bug=757258&attachment=317330)

::: ext/alsa/gstalsasink.c
@@ +451,3 @@
       alsa->format = SND_PCM_FORMAT_S16_LE;
+      /* swap needed if system is big endian */
+      alsa->need_swap = (G_BYTE_ORDER == G_BIG_ENDIAN);

Does not seem correct. We ask the driver for BE, I guess that means we have
negotiated BE. The reason we'd have to swap is not because of our CPU type, but
because what we have miss-match what we have configured. I didn't read the
entire file, please clarify. The comment might be the one you forgot to update.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.