[Bug 765528] gstmpdparser: GstUri changed unexpectedly within combine_urls()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765528

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327196|none                        |needs-work
             status|                            |

--- Comment #8 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 327196:
 --> (https://bugzilla.gnome.org/review?bug=765528&attachment=327196)

Thanks for the patch, a few things  to fix.

Also please follow our commit message style, check git log to see other commits
for reference. And add a valid author/email to the patch.

::: ext/dash/gstmpdparser.c
@@ +3076,3 @@
   g_return_val_if_fail (stream != NULL, NULL);

+  if (!InitializationURL->sourceURL) {

InitializationURL might be NULL, causing a segfault here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.