[Bug 745187] JPEG2000 RTP video streaming problem

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745187

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327551|none                        |needs-work
             status|                            |

--- Comment #10 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327551:
 --> (https://bugzilla.gnome.org/review?bug=745187&attachment=327551)

Thanks for the patch :) Would it be possible to split it up into multiple,
functionally independent commits? It seems like containing several changes,
like for one the consistent usage of the enum you put into the new header file,
the moving of the enum to the header, the handling of the fragmented main
header, the tile index fix, and maybe more.

Having it split up will make it easier to review and helps getting it merged
faster :) Also the commit message should have the format

element/or/plugin: short description
[empty line]
long description of what is done in the commit unless
the short description is already enough.
[empty line]
Link to the bugzilla ticket

::: gst/rtp/gstrtpj2kcommon.h
@@ +1,2 @@
+/* GStreamer */
+

Should have the same license boilerplate at the top as the other files

@@ +27,3 @@
+
+
+#define RTP_J2K_HEADER_SIZE 8

GST/Gst namespace here would be useful

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.