[Bug 758232] Add support for EBU-TT-D / TTML subtitles

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758232

A Ashley <bugzilla at ashley-family.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327038|none                        |needs-work
             status|                            |

--- Comment #25 from A Ashley <bugzilla at ashley-family.net> ---
Review of attachment 327038:
 --> (https://bugzilla.gnome.org/review?bug=758232&attachment=327038)

::: ext/ttml/gstttmlparse.c
@@ +490,3 @@
+
+    GST_DEBUG_OBJECT (self, "Sending buffer %p, %llu %llu",
+        op_buffer, GST_BUFFER_PTS (op_buffer), GST_BUFFER_DURATION
(op_buffer));

This fails to compile for me on 64bit Ubuntu 16.04. To work on both 32bit and
64bit machines, this should be changed to:
GST_DEBUG_OBJECT (self, "Sending buffer %p, %" G_GUINT64_FORMAT " %"
G_GUINT64_FORMAT
        op_buffer, GST_BUFFER_PTS (op_buffer), GST_BUFFER_DURATION
(op_buffer));


Or maybe have the time values in human readable form:
GST_DEBUG_OBJECT (self, "Sending buffer %p, %" GST_TIME_FORMAT " %"
GST_TIME_FORMAT
        op_buffer, GST_TIME_ARGS (GST_BUFFER_PTS (op_buffer)), GST_TIME_ARGS
(GST_BUFFER_DURATION (op_buffer)));

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.