[Bug 766301] qtdemux: Parsing elst box based on version

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766301

--- Comment #2 from Seungha Yang <sh.yang at lge.com> ---
- Current qtdemux does not consider about version of elst box. It causes
incorrect SEGMENT event (i.e., abnormal segment.start value)

- Following is the specification of elst section. 

8.6.6.2
Syntax
aligned(8) class EditListBox extends FullBox(‘elst’, version, 0) {
unsigned int(32) entry_count;
  for (i=1; i <= entry_count; i++) {
    if (version==1) {
      unsigned int(64) segment_duration;
      int(64) media_time;
    } else { // version==0
      unsigned int(32) segment_duration;
      int(32) media_time;
    }
    int(16) media_rate_integer;
    int(16) media_rate_fraction = 0;
  }
}

Log messages are as follows
<NG case>
388 0:00:00.087622976 ^[[336m 5195^[[00m 0x7fdc140f1de0 ^[[37mDEBUG  ^[[00m
^[[00m             qtdemux
qtdemux.c:8420:qtdemux_parse_segments:<qtdemux0>^[[00m looking for edit list
container
389 0:00:00.087626987 ^[[336m 5195^[[00m 0x7fdc140f1de0 ^[[37mDEBUG  ^[[00m
^[[00m             qtdemux
qtdemux.c:8431:qtdemux_parse_segments:<qtdemux0>^[[00m looking for edit list
390 0:00:00.087631099 ^[[336m 5195^[[00m 0x7fdc140f1de0 ^[[33;01mWARN   ^[[00m
^[[00m             qtdemux
qtdemux.c:8497:qtdemux_parse_segments:<qtdemux0>^[[00m found suspicious rate 0
391 0:00:00.087635509 ^[[336m 5195^[[00m 0x7fdc140f1de0 ^[[37mDEBUG  ^[[00m
^[[00m             qtdemux
qtdemux.c:8512:qtdemux_parse_segments:<qtdemux0>^[[00m created segment 0 time
0:00:00.000000000, duration 99:99:99.999999999, media_start 0:02:44.415000000
(3945960) , media_stop 0:02:44.414999999 stop_time 0:02:44.414250000 rate 1,
(0) timescale 24000

<OK case with this patch>
388 0:00:00.028864836 ^[[333m 3782^[[00m 0x7f8e3410f1e0 ^[[37mDEBUG  ^[[00m
^[[00m             qtdemux
qtdemux.c:8420:qtdemux_parse_segments:<qtdemux0>^[[00m looking for edit list
container
389 0:00:00.028868896 ^[[333m 3782^[[00m 0x7f8e3410f1e0 ^[[37mDEBUG  ^[[00m
^[[00m             qtdemux
qtdemux.c:8432:qtdemux_parse_segments:<qtdemux0>^[[00m looking for edit list
390 0:00:00.028873235 ^[[333m 3782^[[00m 0x7f8e3410f1e0 ^[[37mDEBUG  ^[[00m
^[[00m             qtdemux
qtdemux.c:8526:qtdemux_parse_segments:<qtdemux0>^[[00m created segment 0 time
0:00:00.000000000, duration 0:02:44.415000000, media_start 0:00:00.125125000
(3003) , media_stop 0:02:44.540125000 stop_time 0:02:44.415000000 rate 1,
(65536) timescale 24000
391 0:00:00.028883972 ^[[333m 3782^[[00m 0x7f8e3410f1e0 ^[[33;01mWARN   ^[[00m
^[[00m             qtdemux
qtdemux.c:8532:qtdemux_parse_segments:<qtdemux0>^[[00m Segment 0  extends to
0:02:44.415000000 past the end of the file duration 0:02:44.414250000 it will
be truncated

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.