[Bug 758961] adaptivedemux: tests: do not sleep with the GST_TEST_LOCK taken

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri May 13 10:44:34 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=758961

--- Comment #17 from A Ashley <bugzilla at ashley-family.net> ---
Created attachment 327777
  --> https://bugzilla.gnome.org/attachment.cgi?id=327777&action=edit
4/4 - adaptivedemux: tests: don't hold GST_ADAPTIVE_ENGINE_LOCK when calling
callbacks

I've split the patches so that the rename of the GST_TEST_LOCK macro is in its
own commit and also changed the engine to not hold the lock when calling a
callback.

This turned out to be a bit more tricky than I first thought, because by
dropping the lock, other events can get processed by the engine. If one of
these is a pad-removed signal, a stream could get invalidated while another
callback is using it. I've added reference counting that should stop a
GstAdaptiveDemuxTestOutputStream from being released while a callback is in
progress.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list