[Bug 765795] glimagesink: support video frame rotation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765795

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327550|none                        |reviewed
             status|                            |

--- Comment #16 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 327550:
 --> (https://bugzilla.gnome.org/review?bug=765795&attachment=327550)

.

::: ext/gl/gstglimagesink.c
@@ +2290,3 @@
+        (gl_sink->stored_buffer[0]);
+    if (af_meta)
+      gl_sink->transform_matrix = af_meta->matrix;

What if there's a transformation meta and the rotate property is set to
!identity?  We need to combine the two transformations.

::: gst-libs/gst/gl/gstglshaderstrings.c
@@ +45,3 @@
+    "   gl_Position = u_transformation * a_position;\n"
+    "   v_texcoord = a_texcoord;\n"
+    "}\n";

Why do you need another shader? You can do the same with the existing
gst_gl_shader_string_vertex_mat4_texture_transform shader with a slightly
different matrix.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.