[Bug 765052] tracer: add (mini) object leak tracer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765052

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327792|none                        |needs-work
             status|                            |

--- Comment #30 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 327792
  --> https://bugzilla.gnome.org/attachment.cgi?id=327792
add leaks tracer

Looks okay at first glance (haven't tried it yet), we can optimise it later I
suppose.

>+static void
>+set_filtering (GstLeaksTracer * self)
>+  ...
>+    self->filter = g_list_prepend (self->filter, GUINT_TO_POINTER (type));
>+  }
>+  ...
>+}

and

>+static gboolean
>+should_handle_object (GstLeaksTracer * self, gpointer object)
>+{
>+  ...
>+  for (l = self->filter; l != NULL; l = g_list_next (l)) {
>+    GType type = GPOINTER_TO_UINT (l->data);
>+  ...
>+}

I think this is not quite right, sizeof(GType) can be > sizeof(guint).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.