[Bug 766381] v4l2object: use G_SELECTION instead of G_CROP in gst_v4l2_object_acquire_format

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat May 14 09:19:52 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=766381

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 327799:
 --> (https://bugzilla.gnome.org/review?bug=766381&attachment=327799)

Just a question, otherwise looks good.

::: sys/v4l2/gstv4l2object.c
@@ +3667,3 @@
+  memset (&sel, 0, sizeof (struct v4l2_selection));
+  sel.type = v4l2object->type;
+  sel.target = V4L2_SEL_TGT_COMPOSE_DEFAULT;

It's not clear in the spec, I was expecting CROP here instead of compose. Could
you explain ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list