[Bug 766422] videoaggregator: rtspsrc ! compositor produces no output

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766422

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327867|none                        |reviewed
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327867:
 --> (https://bugzilla.gnome.org/review?bug=766422&attachment=327867)

Do we have the same problem in audioaggregator, did you check?

::: gst-libs/gst/video/gstvideoaggregator.c
@@ -1148,3 @@
             GST_DEBUG_OBJECT (pad, "buffer duration is -1, start_time >= "
-                "output_end_running_time. No previous buffer, need more
data");
-            need_more_data = TRUE;

The problem here is that now you might aggregate for the current output time
without having a buffer for this pad. While the buffer for the current time of
this pad might just arrive immediately afterwards and we just didn't get it yet
because the late buffer was on the pad first.

Maybe this should only happen on timeout?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.