[Bug 762216] rtpsession: don't lock while emitting the stats signal

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun May 15 09:33:10 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=762216

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This was fixed independently without test now, sorry!

commit fe34f46f32db15b62b445e82d3c7191f682ddf8b
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Sun May 15 12:30:50 2016 +0300

    rtpsession: Take the lock already when reading the other stats, not just
for the hash table

    https://bugzilla.gnome.org/show_bug.cgi?id=766025

commit 204a86af97d039ddc71cc61bb8bf8a30827c1db1
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed May 11 09:28:13 2016 +0300

    rtpsession: Don't notify about stats property changes while taking the
session lock

    The signal handlers might want to actually get the value of the stats
    property, which would take the session lock again and deadlock.

    This was introduced by 2e960e70750a0cb7e1117d0c09d08597866a29ee.

    https://bugzilla.gnome.org/show_bug.cgi?id=766025

commit 2e960e70750a0cb7e1117d0c09d08597866a29ee
Author: Miguel París Díaz <mparisdiaz at gmail.com>
Date:   Thu May 5 14:18:21 2016 +0200

    rtpsession: Take session lock when creating stats

    The access to the session hash table must happen while the session lock is
    taken, otherwise another thread might modify the hash table while we're
    creating the stats.

    https://bugzilla.gnome.org/show_bug.cgi?id=766025

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list