[Bug 762219] rtpsession: don't act on suspicious BYE RTCP

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun May 15 09:52:23 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=762219

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327922|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327922:
 --> (https://bugzilla.gnome.org/review?bug=762219&attachment=327922)

::: tests/check/elements/rtpsession.c
@@ +678,3 @@
+      g_value_get_boxed (gst_structure_get_value (stats, "source-stats"));
+  g_assert (stats_arr != NULL);
+  fail_unless (stats_arr->n_values >= 1);

I changed this to go through the array, there are > 1 most of the time it seems

@@ +759,3 @@
+  g_assert (gst_test_clock_crank (testclock));
+  gst_buffer_unref (gst_harness_pull (h_rtcp));
+  fail_unless (cb_called);

This often fails

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list