[Bug 631673] add "redirect" message to core

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun May 15 10:16:59 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=631673

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327706:
 --> (https://bugzilla.gnome.org/review?bug=631673&attachment=327706)

free-form structures make sense imho but there should be some API for the
common cases

::: gst/gstmessage.c
@@ +2543,3 @@
+ */
+GstMessage *
+gst_message_new_redirect (GstObject * src)

Maybe parameters for the normal case of just having a single redirect URL, and
other new functions for other common cases?

@@ +2572,3 @@
+void
+gst_message_add_redirect_entry (GstMessage * message, const gchar * location,
+    const GstStructure * entry_struct)

Common fields and their types should at least be documented, even better some
API to set/get common fields (e.g. bitrate).

::: gst/gstquark.h
@@ +208,3 @@
+  GST_QUARK_MESSAGE_REDIRECT = 177,
+  GST_QUARK_ENTRY_LOCATIONS = 178,
+  GST_QUARK_ENTRY_STRUCTURES = 179,

Maybe these should contain the word "redirect"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list