[Bug 578933] Need generic "deep-element-added" signal and/or playbin "element-setup" signal

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=578933

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327936|none                        |reviewed
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 327936:
 --> (https://bugzilla.gnome.org/review?bug=578933&attachment=327936)

::: gst/gstbin.c
@@ +1139,3 @@
+      ires = gst_iterator_foreach (it, bin_deep_iterator_foreach, &elements);
+      if (ires != GST_ITERATOR_DONE) {
+        g_queue_foreach (&elements, (GFunc) g_object_unref, NULL);

You can also get RESYNC which is not really a problem and you just iterate
again

@@ +1146,3 @@
+      GstElement *e;
+
+      while ((e = g_queue_pop_head (&elements))) {

Why don't you just emit in the foreach function? No lock is taken (which is why
you can get RESYNC).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.