[Bug 766524] audio-source: unref private capsfilter reference on finalize

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon May 16 17:11:41 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=766524

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #327996|none                        |needs-work
             status|                            |

--- Comment #8 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 327996:
 --> (https://bugzilla.gnome.org/review?bug=766524&attachment=327996)

::: ges/ges-audio-source.c
@@ +173,3 @@
+
+  if (self->priv->capsfilter)
+    gst_object_unref (self->priv->capsfilter);

You should use gst_object_replace or set it back to NULL, dispose can be called
several times :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list