[Bug 766520] gl: win32: race when handling window messages while creating the internal window
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue May 17 08:37:21 UTC 2016
https://bugzilla.gnome.org/show_bug.cgi?id=766520
Julien Isorce <julien.isorce at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #328010|none |accepted-commit_now
status| |
--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
Review of attachment 328010:
--> (https://bugzilla.gnome.org/review?bug=766520&attachment=328010)
lgtm (just a typo in the title: forcus->focus), also if I am not mistaken it
looks like a fix for your previous fix
https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/gst-libs/gst/gl/win32/gstglwindow_win32.c?id=0acc18c60f6f962cc6553f6047fdb64891bab544
:)
Please add that commit hash in the commit message.
Xavier, could you please check that your patch does not break this example:
https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/tests/examples/gl/gtk/switchvideooverlay
. According to the diff it should not make things worse but worth a try. Thx!
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list