[Bug 766537] identity: add property keep every N-th buffer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766537

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328093|none                        |reviewed
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 328093:
 --> (https://bugzilla.gnome.org/review?bug=766537&attachment=328093)

I'm personally fine with this feature. My only remaining concern is
flexibility. This implementation keep the last of N buffers (an enhancement
would be to document this aspect). I can foresee someone that would like to
keep the first of N instead. Would it be over-engineering to ask for a way to
choose which of Nth buffers to drop ? This could be done with a second
property, or by overloading the meaning of GstFraction (is that too ugly ?) ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.