[Bug 766638] ahc: fix possible NULL deref

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766638

Wonchul Lee <chul0812 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chul0812 at gmail.com

--- Comment #2 from Wonchul Lee <chul0812 at gmail.com> ---
now I got why you added https://bugzilla.gnome.org/show_bug.cgi?id=766637.
I think it would be better something like,

if (!object) {
  GST_WARNING ("android.hardware.Camera.getParameter is NULL");
  return NULL;
}

params = g_slice_new0 (GstAHCParameters);
params->object = gst_amc_jni_object_ref (env, object);
....

instead of checking the object is not null.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.