[Bug 765795] glimagesink: support video frame rotation

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765795

--- Comment #24 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Matthew Waters (ystreet00) from comment #22)
> Review of attachment 327972 [details] [review]:
> 
> .
> 
> ::: ext/gl/gstglimagesink.c
> @@ +191,3 @@
> +  {GST_GL_ROTATE_METHOD_AUTO,
> +      "Select rotate method based on image-orientation tag", "automatic"},
> +  {0, NULL, NULL},
> 
> This is missing the flipped methods that are available in videoflip and
> glvideoflip, i.e. horizontal-flip, vertical-flip, upper-left-diagonal,
> upper-right-diagonal.

Have add these rotate method.

> 
> ::: gst-libs/gst/gl/gstglutils.h
> @@ +119,3 @@
>  
> +void gst_gl_get_affine_transformation_meta_as_ndc
> (GstVideoAffineTransformationMeta * meta, 
> +    const gfloat * rotate_matrix, gfloat * matrix);
> 
> I don't like the changing of this function.
> 
> You should separate out the retrieval and the matrix multiply into another
> function like gst_gl_matrix_multiply()

Just modify the origin _mulyiply_matrix4() function.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.