[Bug 766596] vaapipostproc: some video info is dropped on src caps.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766596

--- Comment #4 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 328168:
 --> (https://bugzilla.gnome.org/review?bug=766596&attachment=328168)

::: gst/vaapi/gstvaapipostprocutil.c
@@ +562,3 @@
+    return FALSE;
+
+  gst_video_info_set_format (&vinfo, format, width, height);

It is a shame that we have to use gst_video_info_set_format for this, since it
is expensive, but I don't see another option either.

@@ +646,3 @@
   if (!_fixate_frame_rate (postproc, vinfo, structure))
     goto fixate_failed;
+  if (!_set_colorimetry (postproc, format, structure))

We also have to check if the processed feature is
GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY. Other features, like GLTextureUpload or
VASurface don't need that information in the caps.

@@ +647,3 @@
     goto fixate_failed;
+  if (!_set_colorimetry (postproc, format, structure))
+    goto fixate_failed;

The only way that colorimetry could fail is if the frame size is not set, which
should failed before. But it is OK to play safe.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.