[Bug 764684] adaptivedemux: Forward upstream buffer offsets

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=764684

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Thiago Sousa Santos from comment #7)
> Is this related to https://bugzilla.gnome.org/show_bug.cgi?id=766647 ?
> 
> Does this offset also include headers/indexes or is it only about the stream
> payload?

I only care about consistent offsets inside a single fragment :) The code
however just passes through the offsets that come from souphttpsrc.

> (In reply to Sebastian Dröge (slomo) from comment #6)
> > How should we proceed with this? The goal here is that downstream of e.g.
> > dashdemux can know where in the stream it is, and then can e.g. handle gaps
> > in the stream (if adaptivedemux e.g. decides to only download and output
> > I-frames).
> > 
> > Patches for that are also in the works :)
> 
> Shouldn't this be handled by using the DISCONT flag? What is the use case to
> knowing exactly the byte offset of the data other than detecting disconts?

You split a single fragment into "virtual" fragments per I-frame (similar to
what the sidx mode does with the individual moof already). And then omit
everything in between. However the demuxer needs to be able to know to which
sample inside the moof the current buffer belongs, and can correlate that with
the buffer offset now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.