[Bug 766650] adaptivedemux: Set DISCONT on startup and after seeks

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766650

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328176|none                        |reviewed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 328176:
 --> (https://bugzilla.gnome.org/review?bug=766650&attachment=328176)

Looks good, just some minor comments.

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +1041,3 @@
     stream->pending_segment = gst_event_new_segment (&stream->segment);
     gst_event_set_seqnum (stream->pending_segment,
demux->priv->segment_seqnum);
+    stream->discont = TRUE;

This seems to be redundant, it should already be true after the change above.

@@ +1467,3 @@
           gst_event_unref (seg_evt);
+          /* Make sure the first buffer after a seek has the discont flag */
+          stream->discont = TRUE;

Is it worth verifying if start/stop was set to avoid sending a discont if
position didn't change?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.