[Bug 766008] (mini)object: add flag marking "leaked" objects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766008

--- Comment #17 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Tim-Philipp Müller from comment #16)
> Comment on attachment 328243 [details] [review]
> use MAY_BE_LEAKED (mini) object flag
> 
> Re. all this set_leaked_foreach() / set_leaked_on_value() /
> priv_gst_buffer_set_may_be_leaked() - did you have a use case where this was
> required in practice?

Yes, all this code has been added after loads of testing in order to have "make
check" passing with all gst components.

> It's technically correct of course, but I would've thought it should only be
> needed if we have buffer fields in static caps, and I don't think one would
> ever do that. Do you remember where this was needed?

We have some here with the 'codec_data' key
https://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/tests/check/elements/qtmux.c#n49

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.