[Bug 766661] gltestsrc,glmosaic: fix shader leaks

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri May 20 15:14:10 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=766661

--- Comment #5 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
commit fe7dd131f5a441fc3f73790bc8447cb454362dc9
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu May 19 17:05:33 2016 +0300

    gltestsrc: fix shaders ref counting

    The gltestsrc element uses two shaders: color_shader and snow_shader.
    Those are alternatively assigned to the SrcShader->shader pointer and
    their reference was transferred to it. Only the SrcShader->shader was
    unreffed (in _src_shader_deinit()) so only one shader was properly
    freed, the other one was leaked.

    Fixed this by giving an extra ref to SrcShader->shader and unreffing the
    2 shaders in _src_smpte_free().

    https://bugzilla.gnome.org/show_bug.cgi?id=766661

commit 2572e3d25c1192faba7bc89d26d26192efdd0481
Author: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>
Date:   Thu May 19 16:55:31 2016 +0300

    glmosaic: fix shader leak

    gst_gl_mosaic_init_shader() is called twice with test_glmosaic so the
    first shader was leaked.

    https://bugzilla.gnome.org/show_bug.cgi?id=766661

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list