[Bug 766719] v4l2transform: Does not fully fixate the caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766719

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328264|none                        |reviewed
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 328264:
 --> (https://bugzilla.gnome.org/review?bug=766719&attachment=328264)

Looks good to me, the extra code to fixate to input format seems useful
considering we also do scaling. In videoconvert they got one extra step which I
don't yet understand:

+  if (direction == GST_PAD_SINK) {
+    if (gst_caps_is_subset (caps, othercaps)) {
+      gst_caps_replace (&othercaps, caps);
+    }
+  }


I'd like to know why they do that and if we should be doing the same here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.