[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328293|none                        |needs-work
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328293:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=328293)

::: ext/openjpeg/gstopenjpeg.h
@@ +56,3 @@
+#define GST_RTP_J2K_GRAYSCALE "GRAYSCALE"
+
+#define GST_RTP_J2K_SAMPLING_LIST "sampling = (string) {\"RGB\", \"BGR\",
\"RGBA\", \"BGRA\", \"YCbCr-4:4:4\",\"YCbCr-4:2:2\", \"YCbCr-4:2:0\",
\"YCbCr-4:1:1\", \"GRAYSCALE\"}"

You could in theory build the list out of the other #defines above to prevent
copying them

::: ext/openjpeg/gstopenjpegenc.c
@@ +640,2 @@
     colorspace = "sYUV";
+    sampling = GST_RTP_J2K_YBR444;

You should take a look at the component subsampling values here. AYUV/Y444 are
4:4:4, I422/Y42B is 4:2:2, I420 is 4:2:0, Y41B is 4:1:1

@@ +643,2 @@
     colorspace = "sRGB";
+    sampling = GST_RTP_J2K_RGB;

Does the order matter here, if so you also need to check those

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.