[Bug 766236] rtp j2k payload/depayload messes up colours in sample pattern

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766236

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328361|none                        |needs-work
             status|                            |

--- Comment #44 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328361:
 --> (https://bugzilla.gnome.org/review?bug=766236&attachment=328361)

::: ext/openjpeg/gstopenjpegenc.c
@@ +642,3 @@
+    case GST_VIDEO_FORMAT_AYUV64:
+    case GST_VIDEO_FORMAT_AYUV:
+      sampling = GST_RTP_J2K_RGBA;

Shouldn't AYUV be YBRA444 or something?

@@ +649,3 @@
+    case GST_VIDEO_FORMAT_Y444_10LE:
+    case GST_VIDEO_FORMAT_Y444_10BE:
+    case GST_VIDEO_FORMAT_Y444:

Do we need to distinguish between 8 bit per component, 10 bit, 16 bit?

@@ +651,3 @@
+    case GST_VIDEO_FORMAT_Y444:
+    case GST_VIDEO_FORMAT_YUV9:
+      sampling = GST_RTP_J2K_YBR444;

YUV9 is 4:1:0

@@ +660,3 @@
+      break;
+    case GST_VIDEO_FORMAT_Y41B:
+      sampling = GST_RTP_J2K_YBR410;

Y41B is 4:1:1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.