[Bug 763762] crash due to gst_iterator_fold which lacks error handling.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon May 23 17:11:54 UTC 2016


https://bugzilla.gnome.org/show_bug.cgi?id=763762

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.1

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
We can't assume that the g_return_if_fail() checks are active, GLib might have
built with -DG_DISABLE_CHECKS or whatever the define is.

Pushed this now:

 commit e0de5ed915f779eaefac7267a54f3aa49837a0bc
 Author: Tim-Philipp Müller <tim at centricular.com>
 Date:   Mon May 23 18:00:30 2016 +0100

    iterator: only unset GValue if it was inited

    And add some function guards. From GLib 2.48 on it is
    allowed to pass an uninitialised GValue to g_value_unset().

    https://bugzilla.gnome.org/show_bug.cgi?id=763762

But really, if you call _fold() with a NULL iterator, all bets are off already,
things went wrong before already then.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list