[Bug 766803] h264parse: add support for config-interval=-1 to re-send SPS/PPS on I/IDR frames

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766803

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328417|none                        |reviewed
             status|                            |

--- Comment #6 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 328417
  --> https://bugzilla.gnome.org/attachment.cgi?id=328417
Add support for config-interval=-1 to re-send SPS/PPS on I/IDR frames

Thanks for the patch!

>+  } else if (h264parse->interval == -1) {
>+    if (h264parse->idr_pos >= 0) {
>+      GST_LOG_OBJECT (h264parse, "IDR nal at offset %d", h264parse->idr_pos);
>+
>+      gst_h264_parse_handle_sps_pps_nals (h264parse, buffer, frame);
>+
>+      /* we pushed whatever we had */
>+      h264parse->push_codec = FALSE;
>+      h264parse->have_sps = FALSE;
>+      h264parse->have_pps = FALSE;
>+      h264parse->state &= GST_H264_PARSE_STATE_VALID_PICTURE_HEADERS;
>+    }
>   }

Any reason this can't go as a simple || addition into the existing if/else
branches? (Honest question, just curious to know if you've considered it and
there's a reason or not).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.