[Bug 766703] glvideomixer: Using an invalid, already destroyed context

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766703

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.9.1

--- Comment #2 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
commit 061a157ef57df81dd1e87ae7a78cdcf94fd42be0
Author: Matthew Waters <matthew at centricular.com>
Date:   Tue May 24 23:39:27 2016 +1000

    glvideomixer: fix race retrieving the GL context from the display

    _get_gl_context() can be called concurrently from either
propose_allocation() or
    decide_allocation().  If it so happens that this happens at the same time,
    the check for whether we already had a GL context was outside the lock. 
Inside
    the lock and loop, the first thing that happens is that we unref the
current GL
    context (if valid) as if there was a conflict adding it to the display.  If
the
    timing was unlucky, subsequent use of the GL context would be referencing
an
    already unreffed GL context object resulting in a critical:

    g_object_ref: assertion 'object->ref_count > 0' failed

    https://bugzilla.gnome.org/show_bug.cgi?id=766703

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.