[Bug 766607] player: problems with unit tests

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=766607

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #328511|none                        |reviewed
             status|                            |

--- Comment #20 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 328511:
 --> (https://bugzilla.gnome.org/review?bug=766607&attachment=328511)

::: gst-libs/gst/player/gstplayer.c
@@ +2744,3 @@

+  g_mutex_lock (&self->lock);
+  self->inhibit_sigs = FALSE;

Also has to happen for gst_player_pause().

Main problem I see here is the uri-loaded signal. This one is triggered even in
stopped state. It happens automatically from the player thread when setting an
URI, so you would inhibit that one now too which seems not very desireable

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.